Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/lucasf #6223

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

feat: add math/base/special/lucasf #6223

wants to merge 31 commits into from

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 20, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/lucasf .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 20, 2025
@hrshya hrshya marked this pull request as draft March 20, 2025 09:09
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 20, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 20, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/lucasf $\color{green}224/224$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}224/224$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hrshya hrshya marked this pull request as ready for review March 20, 2025 11:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 20, 2025
@hrshya
resolve lint errors
bda525f 
Signed-off-by: Harsh <[email protected]>
@hrshya
Copy link
Contributor Author

hrshya commented Mar 22, 2025

@anandkaranubc could you please review this PR?

@anandkaranubc anandkaranubc self-requested a review March 22, 2025 19:24
@hrshya
update README.md
d748e4e 
Signed-off-by: Harsh <[email protected]>
@anandkaranubc anandkaranubc changed the title feat: add math/base/special/lucasf feat: add math/base/special/lucasf Mar 23, 2025
@kgryte
Copy link
Member

kgryte commented Apr 2, 2025

@anandkaranubc Would you mind taking a look at this PR?

@anandkaranubc
Copy link
Contributor

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025
anandkaranubc
anandkaranubc requested changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hrshya, thanks for your work on this! I’ve added some comments on the PR. A few areas need improvement.

lib/node_modules/@stdlib/math/base/special/lucasf/README.md Outdated

#### lucasf( n )

Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

lib/node_modules/@stdlib/math/base/special/lucasf/README.md
<!-- eslint no-undef: "error" -->

```javascript
var lucasf = require( '@stdlib/math/base/special/lucasf' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be refactored to use logEachMap

lib/node_modules/@stdlib/math/base/special/lucasf/README.md Outdated

#### stdlib_base_lucasf( n )

Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

@anandkaranubc anandkaranubc added JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 5, 2025
hrshya and others added 5 commits April 5, 2025 16:44
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/src/addon.c
2e66f7e 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c
5eb3aea 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/examples/c/e…
3de4e3c 
…xample.c

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/lib/main.js
f99b17c 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/lib/index.js
01cac68 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
hrshya and others added 14 commits April 5, 2025 16:46
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/README.md
831b894 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/README.md
ffce25f 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c
53b2641 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c
08d30ea 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c
158f6e4 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/package.json
e84e9e3 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/docs/repl.txt
a842055 
Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/c/…
4f260ba 
…native/benchmark.c

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/c/…
f792e18 
…native/benchmark.c

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/be…
4d923d4 
…nchmark.js

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/c/…
7cc977d 
…native/benchmark.c

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya @anandkaranubc
Update lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/c/…
64d7387 
…benchmark.c

Co-authored-by: Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya
Merge branch 'feat/lucasf' of https://github.com/hrshya/stdlib into f…
06e6456 
…eat/lucasf
@hrshya
fix: fixes suggested changes
a5c0ed6
@hrshya
Copy link
Contributor Author

hrshya commented Apr 6, 2025

@anandkaranubc can you help me out here.

@anandkaranubc
Copy link
Contributor

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025
@anandkaranubc
Copy link
Contributor

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025
@stdlib-bot
Copy link
Contributor

/stdlib lint-autofix

@anandkaranubc, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025
anandkaranubc
anandkaranubc reviewed Apr 6, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/benchmark.js Outdated
Comment on lines 69 to 72

// TODO: replace with `powf` when available
return roundf( pow( PHI, n ) );
}
Copy link
Contributor

@anandkaranubc anandkaranubc Apr 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrshya, this needs to be fixed. There is a missing function implementation. This is the primary reason why the CI/CD workflows are failing. It's a good practice to run the benchmarks locally first to confirm if nothing is broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did ran the benchmarks when I first created the PR but not this time because there were any major changes in those files.

@anandkaranubc
Copy link
Contributor

anandkaranubc commented Apr 6, 2025 •
edited
Loading

As a side note, always make sure your feature branch is in sync with the develop branch. This was the reason why there were many unrelated file changes in your previous commits.

Discussion

@hrshya
Copy link
Contributor Author

hrshya commented Apr 6, 2025

As a side note, always make sure your feature branch is in sync with the develop branch. This was the reason why there were many unrelated file changes in your previous commits.

Discussion

Actually it was in sync but the thing was I didn't have this branch locally so I pulled it from origin and i thought as my develop branch is in sync so this branch would also be but i was wrong and i should have checked it before commiting

@hrshya
Copy link
Contributor Author

hrshya commented Apr 6, 2025

@anandkaranubc All the issues have been resolved. Can you give it a quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandkaranubc anandkaranubc anandkaranubc requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
C Issue involves or relates to C. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrshya @stdlib-bot @kgryte @anandkaranubc